Add detection of WSL when starting the debug container #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Windows, HA |
|
@LeeSaferite When you tested this, was it on WSL1 or WSL2? |
|
This is on WSL1. The release name contains |
|
Verified this doesn't change behavior on either macOS nor on Fedora 31. Looks good. Thanks for the contribution @LeeSaferite |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code for
warden debugdoes not detect WSL based environments and instead identifies them as standard Linux. This becomes a problem when trying to configure the Xdebug remote connect address. The Windows version of Docker has the magic "host.docker.internal" hostname that the Linux version of Docker does not have. Additionally, the fallback method of remote IP detection fails to generate the correct IP address on a WSL setup. This test is the suggested way of detecting a WSL Linux system.microsoft/WSL#423 (comment)